Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make generated Dart opaque class abstract to improve testability #2032

Merged
merged 72 commits into from
Jun 4, 2024
Merged

Make generated Dart opaque class abstract to improve testability #2032

merged 72 commits into from
Jun 4, 2024

Conversation

fzyzcjy
Copy link
Owner

@fzyzcjy fzyzcjy commented Jun 4, 2024

Changes

Please list issues fixed by this PR here, using format "Fixes #the-issue-number".

Checklist

  • An issue to be fixed by this PR is listed above.
  • New tests are added to ensure new features are working. Please refer to this page to see how to add a test.
  • ./frb_internal precommit --mode slow (or fast) is run (it internal runs code generator, does auto formatting, etc).
  • If this PR adds/changes features, documentations (in the ./website folder) are updated.
  • CI is passing. Please refer to this page to see how to solve a failed CI.

Remark for PR creator

  • ./frb_internal --help shows utilities for development.
  • If fzyzcjy does not reply for a few days, maybe he just did not see it, so please ping him.

@fzyzcjy fzyzcjy changed the title Make generate Dart opaque class abstract to improve testability Make generated Dart opaque class abstract to improve testability Jun 4, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 95.48023% with 8 lines in your changes missing coverage. Please review.

Project coverage is 98.32%. Comparing base (b11569e) to head (ad99b17).

Files Patch % Lines
.../generator/api_dart/spec_generator/class/method.rs 85.45% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2032      +/-   ##
==========================================
- Coverage   98.37%   98.32%   -0.06%     
==========================================
  Files         419      419              
  Lines       17160    17290     +130     
==========================================
+ Hits        16882    17001     +119     
- Misses        278      289      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fzyzcjy fzyzcjy marked this pull request as ready for review June 4, 2024 23:55
@fzyzcjy fzyzcjy merged commit 96edf24 into master Jun 4, 2024
103 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fzyzcjy